Deduplicate PaymentReceived events on restart #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinsaposnic
approved these changes
Jan 20, 2026
martinsaposnic
left a comment
martinsaposnic
left a comment
There was a problem hiding this comment.
nit: contains_payment_received can be private
@f3r10 this needs to be cherry picked to your branch?
f3r10
approved these changes
Jan 21, 2026
the logic of the new version is pretty much the same, so yes, it would be necessary to be cherry picked on the respective branch |
PaymentClaimed events can be replayed on every Node startup. Since nodes are pinged at minimum every 30 minutes, this causes duplicate PaymentReceived events to stack up in the queue when the event queue is not being actively processed. These stacked events can cause payouts to fail as they timeout before the queue is drained to the actual events related to a payout. Add a check before queuing PaymentReceived to skip if an event for that payment_id already exists in the queue, preventing duplicates.
amackillop
force-pushed
the
austin/mdk-415/dedupe-payment-received-events
branch
from
2a534c4 to
57a2dbf
Compare
Author
@martinsaposnic Fixed and squashed |
amackillop
added a commit
that referenced
this pull request
Jan 21, 2026
PaymentClaimed events can be replayed on every Node startup. Since nodes are pinged at minimum every 30 minutes, this causes duplicate PaymentReceived events to stack up in the queue when the event queue is not being actively processed. These stacked events can cause payouts to fail as they timeout before the queue is drained to the actual events related to a payout. Add a check before queuing PaymentReceived to skip if an event for that payment_id already exists in the queue, preventing duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaymentClaimed events can be replayed on every Node startup. Since nodes are pinged at minimum every 30 minutes, this causes duplicate PaymentReceived events to stack up in the queue when the event queue is not being actively processed.
These stacked events can cause payouts to fail as they timeout before the queue is drained to the actual events related to a payout.
Add a check before queuing PaymentReceived to skip if an event for that payment_id already exists in the queue, preventing duplicates.