Soil layer bug#32
Open
mpaiao wants to merge 1 commit into
Open
Conversation
…o run with more than four soil layers. The logic in mpas_atmphys_driver_lsm_noahmp.F can be simplified to a single loop that will always work. Likewise, Registry_noahmp.xml does not need to have the combined number of soil plus snow levels (nzSoilLevels) hardcoded, it can be written as the sum of the levels so it always works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is a rather cryptic bug, that only occurs when the number of soil layers is not the default (4 layers) for Noah-MP, which results in the model not conserving water.
1. Soil layer indexing bug. Noah-MP uses positive indices for soil layers, and negative indices for snowpack layers. In sub-routine
lsm_noahmp_toMPAS, the code copies the depths from Noah-MP to a local structure (zsnsoxy) that assumes indices going from 1 to the number of combined snowpack and soil layers. However, the original code had one error in the conversion logic, which coincidentally worked for the specific case in which the number of soil layers is exactly the number of snowpack ayers plus 1. The proposed change is used elsewhere in the code and ensures the conversion always works.2. Hardcoded number of soil plus snow levels. File
Registry_noahmp.xmloriginally defines dimensionnzSnowLevels(total number of soil plus snowpack layers) as 7. This works when using the default number of soil layers, but causes segmentation violations otherwise.This is a quick hot fix, which will be followed by a subsequent pull request that allows for a more flexible definition of soil levels for Noah and Noah-MP.
Type of Change
Testing and Quality
Scientific Impact
Bug fix. This will not impact simulations using the default number of layers, but it will allow generalising the solution for soils with more layers.