Fix Windows 3.11 issue with internet explorer dialup driver.

[massej]

I would also add to try the "Manual login" in Trumpet as for me I don't know why but the automatic mode never worked but in manual mode by typing ATDT1 and ESC it worked

http://www.steptail.com/guides:connecting_windows_3.1_to_the_internet

[molivil]

Sounds good. If you would like to make any additions on the official documentation over at www.steptail.com <http://www.steptail.com> , you can send me your update to ***@***.*** ***@***.***> and I can put them on there. Oliver Molini Steptail & Protoweb Team <http://www.steptail.com/> www.steptail.com | <http://www.protoweb.org/> www.protoweb.org (682) 219-9850 (international callers, please dial prefix +1) From: massej ***@***.***> Sent: Thursday, 1 February 2024 15.44 To: molivil/vmodem ***@***.***> Cc: Subscribed ***@***.***> Subject: [molivil/vmodem] Fix Windows 3.11 issue with internet explorer dialup driver. (PR #7) I would also add to try the "Manual login" in Trumpet as for me I don't know why but the automatic mode never worked but in manual mode by typing ATDT1 and ESC it worked http://www.steptail.com/guides:connecting_windows_3.1_to_the_internet

…

_____ You can view, comment on, or merge this pull request online at: #7 Commit Summary * 99fa953 <99fa953> Fix Windows 3.11 issue with internet explorer dialup driver. * 33b92be <33b92be> Update vmodem.sh File Changes (1 <https://github.com/molivil/vmodem/pull/7/files> file) * M vmodem.sh <https://github.com/molivil/vmodem/pull/7/files#diff-6f0e6562d79cb135847f5aa442421e8e8fe746e0d140fc4d36fcc1ed6006f755> (586) Patch Links: * https://github.com/molivil/vmodem/pull/7.patch * https://github.com/molivil/vmodem/pull/7.diff — Reply to this email directly, view it on GitHub <#7> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOXUDN6NHPJUQAZN6FTSMETYRQEATAVCNFSM6AAAAABCVUOHGSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTGNJTHE2DIMA> . You are receiving this because you are subscribed to this thread. <https://dl.efa-project.org/static/1x1spacer.gif> Message ID: ***@***.*** ***@***.***> > [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#7", "url": "#7", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[henk717]

Been basing my own version off of this PR and while testing I noticed Win3.11 doesn't always add the spaces which can then trip up your logic for removing the ringing.

This is the check I used instead : if [[ $cmd == ATX4D* ]]; then

[massej]

@henk717

I’m curious, which lines did you changes?

can you provide an example of your script?

[henk717]

This particular one is a small change on line 189.
You check if the number resulted in 0, my check instead checks if it begins with ATX4D which also covers numbers where the spaces are missing.

[massej]

I think i found the issue

ATX4D*

You are dialing * ?

I think line 183 need to be replaced ( to add # and * )

like

number=$(echo "$hparm" | tr -dc '0-9*#')

[henk717]

No the * there should represent a wildcard so anythiny I dial with ATX4D then activates your Windows 3.11 workaround. For example ATX4D11 which is the number I dial does not put spaces in front. With my ATX4D* the check passes and the no ringing workaround gets applied.

Your version according to the comment looks for an invalid number which the spaces cause which works for "ATX4D 1" but fails on "ATX4D11" as it resolves to 11 correctly. That causes the fixes for w3.11 to fail and then we hang on dialup.

So instead of checking for an invalid number mine checks if ATX4D is present.

[massej]

Thanks for the finding

The script should be better now.

Best,