perf(web-api): ускорение product/list (Data prefetch, COUNT, content) - #587
Open
Ibochkarev wants to merge 1 commit into
Open
perf(web-api): ускорение product/list (Data prefetch, COUNT, content)#587Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Avoid per-row getOne(Data) on product/list, drop useless COUNT DISTINCT for the 1:1 Data join, and skip selecting content when include_content is off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Hot path
GET /api/v1/product/listбольше не делает N×getOne('Data')на страницу.getCollection— один batchmsProductData(id:IN) +addOne(..., 'Data'), чтобыloadData()брал кэш.COUNT(msProduct.id)вместоCOUNT(DISTINCT …)при 1:1 JOIN.include_content=0list-select исключает колонкуcontent(какms3_products).msOnGetProductPrice|Weight|Fieldsи JSON-контракт без изменений.Тип изменений
Связанные Issues
Closes #575
Как это было протестировано?
Gate E:
Конфигурация: ветка от
beta, PHP 8.xЧеклист
Дополнительные заметки
JOIN Data в list-query по-прежнему для WHERE/ORDER; hydrate related из JOIN в xPDO
getCollectionнет, поэтому отдельный IN-prefetch в бюджете AC (≈2–4 SQL: count + list + data). Runtime query-counter на stub xPDO — follow-up к #574.