feat(grid): фильтрация товаров категории по relation-колонкам - #585
Open
Ibochkarev wants to merge 1 commit into
Open
feat(grid): фильтрация товаров категории по relation-колонкам#585Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Apply filter_{field} LIKE on joined relation display fields and send the same prefix from the manager grid so UI filters match option-column behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
В гриде товаров категории relation-колонки уже JOIN/SELECT/sort, но
filter_{fieldName}обрабатывался только для option. Фильтр по адресу вендора и подобным полям молча игнорировался.Теперь
CategoryProductsListServiceприменяет LIKE по display-полю связанной таблицы (тот же JOIN иsortExpression(), что для сортировки).CategoryProductsGridшлётfilter_*и дляtype === 'relation'.Тип изменений
Связанные Issues
Closes #582
Как это было протестировано?
Gate E:
composer test:smoke, focused smoke, eslint path)Конфигурация тестирования:
feat/issue-582-relation-column-filterотbetaЧеклист
Дополнительные заметки
Review: Vue-префикс
filter_для relation был обязателен; без него PHP-only не закрывал симптом из #328. Source-contract smoke для PHP+Vue — в духе существующих smoke-тестов репозитория.