fix(web-api): hardening rate-limit, CORS wildcards, query tokens - #584
Open
Ibochkarev wants to merge 1 commit into
Open
fix(web-api): hardening rate-limit, CORS wildcards, query tokens#584Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Ключ rate limit только по IP, CORS-паттерны через preg_quote и одну DNS-метку, session token не принимается из query string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Закрывает три находки security-аудита Web API (#576):
REMOTE_ADDR(без client-controlledHTTP_MS3TOKEN).preg_quote+*→[^.]+(одна DNS-метка), без «голых» точек в regex.MS3TOKEN/ cookie / session; queryms3_tokenснимается и не является credential.Тип изменений
?ms3_token=больше не авторизует)Связанные Issues
Closes #576
Как это было протестировано?
Конфигурация тестирования:
fix/issue-576-web-api-security-hardeningЧеклист
Дополнительные заметки
RateLimiterне менялся.?token=на маршруте без TokenMiddleware — без регрессии.