Skip to content

refactor: app dir move logic - #8281

Merged
IMB11 merged 7 commits into
mainfrom
cal/app-dir-move-logic-redo
Nov 11, 2026
Merged

IMB11 merged 7 commits into
mainfrom
cal/app-dir-move-logic-redo

Conversation

@IMB11

@IMB11 IMB11 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

See header comment

  • test on windows
  • change ui to be cleaner

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Note

This changelog has been baked. Any further edits will not be reflected.

Pull request changelog

App

Added

Changed

  • Redesigned the App directory setting in Resource management settings.
    • Selecting the current app directory path copies it to the clipboard.
    • Change directory opens a modal that shows the current and new folders, with options to move and restart now or move on next launch.
    • A pending move shows a warning with options to cancel the move or move and restart now.
    • The Change directory modal blocks a folder inside the current app directory, or one that contains it, and asks you to close running instances first.
    • The Change directory modal recommends a folder over the top level of a drive.
  • Moving the app directory copies files in parallel and checks every copied file before Modrinth App switches to the new folder.
  • The splash screen shows the progress of an app directory move with the message "Moving your app directory...".

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Queue requested — the merge queue status continues in this comment ↓.

@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[High impact] The PR changes a startup workflow that moves existing app data between directories.

Fix destination-file protection before merging; the move can silently overwrite different data.

Summary

Refactors app-directory moves into a parallel copy plan with hash checks, retries, deferred disk saves, and byte-based splash progress.

  • App directory moves copy planned files together and check them before switching paths.
  • The splash screen tracks app-directory moves while they run.

Reviews (1) · Last reviewed commit: "refactor: app dir move logic" · Reviewed by Greptile

@IMB11

IMB11 commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

🚫 Left the queue · pull request merged manually

1 min in the queue, with no time running CI.

So far

Reason

Pull request #8281 has been merged manually at b283683

Hint

You were too fast!

Tick the box to put this pull request back in the merge queue (same as @mergifyio queue).

  • Requeue this pull request
2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-skipped = Lint and Test
    • check-neutral = Lint and Test
    • check-success = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 11, 2026
@mergify mergify Bot mentioned this pull request Nov 11, 2026
6 of 10 tasks
@IMB11
IMB11 merged commit b283683 into main Nov 11, 2026
16 of 25 checks passed
@IMB11
IMB11 deleted the cal/app-dir-move-logic-redo branch November 11, 2026 18:30
@mergify

mergify Bot commented Nov 11, 2026

Copy link
Copy Markdown

queue

☑️ The pull request has been merged manually

Details

The pull request has been merged manually at b283683

@mergify mergify Bot removed the queued label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants