[IMB11]

[github-actions]

Note

This changelog has been baked. Any further edits will not be reflected.

Pull request changelog

App

Added

• Reset to default button next to each setting on the Java and memory, Window, and Launch hooks tabs of instance settings.
• Save and discard bar in instance settings, which asks before you switch tabs or close with unsaved changes.
• Recommended Java version for the instance's Minecraft version on the Java and memory tab of instance settings.

Changed

• Removed the override toggles from the Java and memory, Window, and Launch hooks tabs of instance settings.
  • Settings show the default value until you change it.
  • Changed settings save only when you select Save.
• Redesigned the Java installation picker in instance settings and app settings.
  • The selected path copies to the clipboard when selected.
  • A label shows whether the selected Java installation is valid.
  • Browse and Edit path moved into the menu next to the Detect button.
  • Install Java now names the version that it installs.
• Instances that use the default Java installation now use the installed Java version that the instance's Minecraft version recommends.
• Renamed "Custom memory allocation", "Custom Java arguments", "Custom environment variables", and "Custom Java installation" in instance settings to remove "Custom".
• Width and height in instance window settings each have their own reset button.
• Replaced the fade at the bottom of the settings sidebar with a divider line.

Deprecated

Removed

Fixed

• Fixed extra space at the bottom of the app settings sidebar when no update is downloading.

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge, with a non-blocking issue where Java settings can show an outdated recommendation.

Summary

Replaces instance override toggles with editable values and reset buttons.

• Instance settings save edits together and reset each field separately.
• Java settings share a selector for paths, detection, and installs.
• App settings use the same shared host for unsaved edits.
• Settings footer markup and a Hosting sentence get small text and layout edits.

Both supplied previous threads are addressed: reset buttons check whether an override exists, and draft setup runs before asynchronous requests. Neither thread supplied a comment number.

_{Reviews (2) · Last reviewed commit: "refactor: cleanup" · Reviewed by Greptile}

[tdgao]

lgtm

[mergify]

Queue requested — the merge queue status continues in this comment ↓.

[IMB11]

@Mergifyio queue

[mergify]

🛑 Queue command cancelled

Queue requested — the merge queue status continues in this comment ↓.

[mergify]

queue

🛑 The queue request has been cancelled: new commits were pushed

Details

@IMB11 pushed to this pull request after queue was requested. Review the new commits and request it again.

[mergify]

✅ Merged into main as ae7fde4 at 13:35 UTC

Less than a minute in the queue, with no time running CI.

So far

• ✅ Entered the queue Wed 11 Nov, 13:35 · rule default · triggered by @IMB11 with the merge queue checkbox
• ✅ Checks skipped · PR is already up-to-date
• ✅ Merged 13:35 · ae7fde4

2 merge conditions met

• github-review-approved · required by GitHub branch protection
• any of · required by GitHub branch protection:
  • check-success = Lint and Test
  • check-neutral = Lint and Test
  • check-skipped = Lint and Test

_{Times in UTC · dashboard · how the merge queue works}