Skip to content

feat: tech rev in modview - #8162

Merged
mergify[bot] merged 53 commits into
mainfrom
truman/tech-rev-in-modview
Nov 11, 2026
Merged

mergify[bot] merged 53 commits into
mainfrom
truman/tech-rev-in-modview

Conversation

@tdgao

@tdgao tdgao commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is a7d1dfbe8e5db58ee187f0cbc50d0f3e90692cbb

Persistent

Environment URL
staging https://pr-8162.frontend-staging.rinth.dev
production https://pr-8162.frontend.rinth.dev
storybook https://pr-8162-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://49911b96.frontend-staging.rinth.dev
production https://d4a1f3df.frontend.rinth.dev

tdgao added 23 commits October 29, 2026 22:24
@tdgao
tdgao marked this pull request as ready for review November 5, 2026 18:50
@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[High impact] The PR changes the shared moderation workflow for technical-review decisions.

Restore queue access for approved projects needing technical review and satisfy the story and plain-English requirements before merging.

Summary

Moves technical review into the project-review workspace.

  • Technical review now runs inside the project-review workspace.
  • Technical-review submissions include issue counts and queue status.
  • Technical-review findings and reviewer controls join the moderation settings.
  • Shared menus, scrolling, and message editing support the review workspace.

Reviews (1) · Last reviewed commit: "pnpm prepr:frontend" · Reviewed by Greptile

@greptile-apps

greptile-apps Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff

These findings could not be posted inline.

  • P1 Flagged projects lose queue access apps/frontend/src/pages/moderation/technical-review/index.vue:401 ▶

    Deleting this page removes the queue view for already-approved projects that need technical review. The replacement page calls getProjects and getProjectIds, which only return projects whose status is processing. A Delphi rule change can add an approved project to delphi_tech_review_queue without changing its status, so reviewers can no longer discover that work from the queue. Keep a technical-review queue view or extend the replacement list to include these projects.

@tdgao

tdgao commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify

mergify Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

🛑 Queue command cancelled

Queue requested — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Nov 11, 2026

Copy link
Copy Markdown

queue

🛑 The queue request has been cancelled: new commits were pushed

Details

@tdgao pushed to this pull request after queue was requested. Review the new commits and request it again.

@tdgao

tdgao commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify

mergify Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

✅ Merged into main as ecf116d at 16:33 UTC

Less than a minute in the queue, with no time running CI.

So far

  • ✅ Entered the queue Wed 11 Nov, 16:33 · rule default · triggered by @tdgao with the @mergifyio queue command
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged 16:33 · ecf116d
2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-success = Lint and Test
    • check-neutral = Lint and Test
    • check-skipped = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 11, 2026
@mergify
mergify Bot merged commit ecf116d into main Nov 11, 2026
16 checks passed
@mergify
mergify Bot deleted the truman/tech-rev-in-modview branch November 11, 2026 16:33
@mergify mergify Bot removed the queued label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants