Skip to content

fix(labrinth): let fabric-family loaders share a version with other loaders' game versions - #7930

Open
rhysdh540 wants to merge 1 commit into
modrinth:mainfrom
rhysdh540:main
Open

rhysdh540 wants to merge 1 commit into
modrinth:mainfrom
rhysdh540:main

Conversation

@rhysdh540

Copy link
Copy Markdown

validate_game_versions required every game version on an upload to fall in each Fabric-family loader's range. so for example a single jar supporting fabric + ornithe across 1.12.2 and 1.21.11 was rejected.

now, each of fabric, legacy-fabric, babric and bta-babric needs at least one game version in its range (all → any).

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request

@Prospector

Copy link
Copy Markdown
Member

ideally it should require every game version to be in the range of at least one of the loaders it supports

@rhysdh540

Copy link
Copy Markdown
Author

i think it has to be twofold in some way, since your rule flips the question from “does each loader have a version?” to “does each version have a loader?”

so for example consider fabric + legacyfabric on [1.12.2, 1.21, b1.7.3]: with this pr it's allowed, but with your rule it's rejected, because nothing covers b1.7.3.

but consider fabric + legacyfabric on [1.12.2] only: with this pr it's rejected, but with your rule it's allowed, since legacyfabric covers 1.12. but fabric gets no valid version at all.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants