Skip to content

Bump frontend version upload timeout #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdgao merged 1 commit into from
Jun 8, 2026
+9 −2
Merged

Bump frontend version upload timeout #6333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/api-client/src/modules/labrinth/versions/v3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { AbstractModule } from '../../../core/abstract-module'
import type { UploadHandle } from '../../../types/upload'
import type { Labrinth } from '../types'

const VERSION_UPLOAD_TIMEOUT_MS = 30 * 60 * 1000

export class LabrinthVersionsV3Module extends AbstractModule {
public getModuleID(): string {
return 'labrinth_versions_v3'
Expand Down Expand Up @@ -199,7 +201,7 @@ export class LabrinthVersionsV3Module extends AbstractModule {
api: 'labrinth',
version: 3,
formData,
timeout: 60 * 5 * 1000,
timeout: VERSION_UPLOAD_TIMEOUT_MS,
})
}

Expand Down Expand Up @@ -284,7 +286,7 @@ export class LabrinthVersionsV3Module extends AbstractModule {
api: 'labrinth',
version: 2,
formData,
timeout: 60 * 5 * 1000,
timeout: VERSION_UPLOAD_TIMEOUT_MS,
})
}
}
5 changes: 5 additions & 0 deletions packages/api-client/src/platform/xhr-upload-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ export abstract class XHRUploadClient extends AbstractModrinthClient {

xhr.addEventListener('error', () => reject(new ModrinthApiError('Upload failed')))
xhr.addEventListener('abort', () => reject(new ModrinthApiError('Upload cancelled')))
xhr.addEventListener('timeout', () => reject(new ModrinthApiError('Upload timed out')))

if (context.options.timeout !== undefined) {
xhr.timeout = context.options.timeout
}

// build URL with params (unlike $fetch, XHR doesn't handle params automatically)
let url = context.url
Expand Down
Loading