Fix threadmenu command execution#3429
Merged
sebkuip merged 2 commits intodevelopmentfrom Mar 14, 2026
Merged
Conversation
This commit fixes the command execution for the threadmenu that caused commands to be sent to the recipient DM instead of the thread channel.
lorenzo132
approved these changes
Jan 3, 2026
Member
lorenzo132
left a comment
lorenzo132
left a comment
There was a problem hiding this comment.
Can confirm this resolves the issue after some testing.
Contributor
Author
|
We should soon implement these changes with the other threadmenu fixes to make it easier for users with the transition. |
martinbndr
requested review from
StephenDaDev
and removed request for
StephenDaDev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the command execution for the threadmenu that caused commands to be sent to the recipient DM instead of the thread channel.
The root cause was that the source message (users DM) was used to generate the context for the commands being executed. Now it uses the thread genesis_message to create all needed info for the commands to be run. Responses will be forwarded to the thread channel.
Credits to the advanced menu plugin from @sebkuip which has realized it that way.