Skip to content

Fix condition for richards laytyp check in mfusglpf.py - #2812

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
martinvonk:patch-1
Aug 13, 2026
Merged

Fix condition for richards laytyp check in mfusglpf.py#2812
wpbonelli merged 1 commit into
modflowpy:developfrom
martinvonk:patch-1

Conversation

@martinvonk

Copy link
Copy Markdown
Contributor

This check (self.laytyp==5) always defaults to False as self.laytyp is a MFArray due to the super().__init__. Therefore, if laytyp=5 parsed to the MfUsgLpf.init, self.richards will always be False and unsaturated flow won't be simulated.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.3%. Comparing base (556c088) to head (9e30eb9).
⚠️ Report is 204 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2812      +/-   ##
===========================================
+ Coverage     55.5%    73.3%   +17.7%     
===========================================
  Files          644      659      +15     
  Lines       124135   132182    +8047     
===========================================
+ Hits         68947    96907   +27960     
+ Misses       55188    35275   -19913     
Files with missing lines Coverage Δ
flopy/mfusg/mfusglpf.py 74.0% <100.0%> (-6.4%) ⬇️

... and 584 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli added this to the 3.11 milestone Aug 13, 2026
@wpbonelli wpbonelli added the bug label Aug 13, 2026
@wpbonelli
wpbonelli merged commit a222eba into modflowpy:develop Aug 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants