fix(mf6): omit removed fields from generated code - #2804
Open
wpbonelli wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2804 +/- ##
==========================================
+ Coverage 55.5% 70.1% +14.6%
==========================================
Files 644 315 -329
Lines 124135 66066 -58069
==========================================
- Hits 68947 46345 -22602
+ Misses 55188 19721 -35467
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter out fields marked in DFNs as
removedfrom the generated classes in the MF6 module. Before, removed fields were included in the generated classes and would be written to input files, which would cause MF6 to raise an error.And update usages of
inner_hcloseandouter_hclose, these options have recently been removed from MF6.