test: pin derived sub-object serialization chaining (NestedInheritance snapshot) - #56
Merged
Merged
Conversation
…e snapshot) Guards that a [SerializationGenerator] class deriving from another non-ISerializable generated class emits override Serialize/Deserialize that chain to base, inherits MarkDirty and the dirty-tracking parent, and that a List<Derived> owner constructs elements through the base-chain parent constructor. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ug9bDSDgecZNYdk9j7QE38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
NestedInheritancesnapshot fixture that pins the generator's behaviour for a derived non-ISerializablesub-object (DerivedEntry : BaseEntry, both[SerializationGenerator], tracked through a[DirtyTrackingEntity]on the base) owned through aList<DerivedEntry>on a derived owner.The fixture asserts, byte for byte, that:
public override void Serialize/Deserializeand callsbase.Serialize(writer)/base.Deserialize(reader)before writing its own version and fields;MarkDirty()is inherited from the base (not re-emitted), and[DirtyTrackingEntity]resolves through the base;new DerivedEntry(this)via the parent-accepting constructor found on the base chain;[AfterDeserialization]runs after its own fields, base first.No generator code changes. This shape is about to be relied on by a spawner subclass with its own entry type, so it should be a regression guard rather than an accident.
Tests
dotnet test— 115 passed (114 existing + the new fixture).