Replace BenchmarkTools.jl with Chairmarks.jl in Optimizing#138
Merged
jacobusmmsmit merged 5 commits intomodernjuliaworkflows:mainfrom Sep 9, 2025
nathanrboyer:nb/chairmarks
Merged
Replace BenchmarkTools.jl with Chairmarks.jl in Optimizing#138jacobusmmsmit merged 5 commits intomodernjuliaworkflows:mainfrom nathanrboyer:nb/chairmarks
jacobusmmsmit merged 5 commits intomodernjuliaworkflows:mainfrom
nathanrboyer:nb/chairmarks
Conversation
adrhill
requested changes
Sep 1, 2025
gdalle
requested changes
Sep 1, 2025
Collaborator
gdalle
left a comment
gdalle
left a comment
There was a problem hiding this comment.
Thanks for this contribution! I rephrased it in a slightly less opinionated way, because I think BenchmarkTools is far from dead
Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com>
Collaborator
|
Encouraging use of Chairmarks could collectively save humanity a lot of time waiting about! Let's get this closed. |
adrhill
approved these changes
Sep 8, 2025
Contributor
Author
|
@jacobusmmsmit's change looks good to me! It would be nice to have a page in the Chairmarks documentation about compiler optimizations, but this is good enough for now. I'm a git newb, so I'm not sure if there is something I need to do to approve or pull your commit, but this looks ready to merge to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133.