perf(sqlite): add indexes for hot query paths - #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite-backed workspaces currently scan and sort entire tables for several common reads. This adds six targeted indexes for:
The indexes are created with
IF NOT EXISTSafter legacy schema migrations, so existing Durable Objects and local databases upgrade safely on first startup.Performance
Synthetic in-memory SQLite benchmark with 100,000 posts, 200,000 comments, and 50,000 assets; values are medians from 30 warm runs:
Building all six indexes took 124 ms in this synthetic in-memory database. Existing databases pay this construction cost once after upgrading.
Testing
This PR description was generated by Pi using GPT-5.6 Sol