feat(extensions): add four-edge panes and current-line paint - #710
Open
benvinegar wants to merge 7 commits into
Open
feat(extensions): add four-edge panes and current-line paint#710benvinegar wants to merge 7 commits into
benvinegar wants to merge 7 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benvinegar
force-pushed
the
feat/split-line-lens
branch
from
August 11, 2026 15:12
97e8cab to
301f83e
Compare
benvinegar
marked this pull request as ready for review
August 11, 2026 15:38
Member
Author
|
@greptile-ai review |
Member
Author
|
@greptile-apps review This comment was generated by Pi using gpt-5.6-sol |
Contributor
Greptile SummaryThe PR generalizes extension sidebars into host-planned panes on all four terminal edges and adds an optional current-line lens using the public pane API.
Confidence Score: 5/5The PR appears safe to merge; no concrete blocking or independently actionable non-blocking issues remain. The pane planner preserves minimum review bounds, extension failures are contained with replacement fallback, and current-line paint is derived from and invalidated with the authoritative row plan. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
R[Extension registrations] --> A[Registry and apply path]
A --> S[Session pane model]
S --> P[Four-edge rectangle planner]
P --> L[Left and right panes]
P --> H[Top and bottom panes]
P --> D[Residual DiffPane bounds]
D --> C[Accepted current-line row plan]
C --> O[Opaque current-line painter]
O --> H
Reviews (1): Last reviewed commit: "test(pty): wait for complete resize fram..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
widthcontract for left/right panes andheightcontract for top/bottom panesCloses #638.
Testing
bun run formatbun run typecheckbun run lintbun run check:docsbun run build:npmbun run check:packbun run website:buildbun test ./src ./packages ./test/cli ./test/session— 1,956 passed, 9 skippedbun run test:integration— 105 passedbun run test:tty-smoke— 9 passedexamples/extensions/current-line-lens/This PR description was generated by Pi using gpt-5.6-sol