Repository navigation
test(controller-local): match the ssh stub's readiness commands exactly - #252
Merged
Merged
Conversation
The ssh stub answered "exit 0, no output" for any remote command containing 6080, cloud-init or boxery-provision. A copy's staging script carries a random 24-hex-digit id, so about one run in 3,000 the id contained 6080: the stub then pretended a missing VM had staged the copy, and cp failed with "unexpected staging response" instead of "no such vm" (seen on master, macos-shell). The stub now matches the three commands it stands in for: cloud-init status, the noVNC readiness loop and the provisioning check. None can appear in a hex id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos-shellfailed on master atf9dee59with one check intest/shell/common/controller-local.sh:Cause. The test's ssh stub exits 0 with no output for any remote command containing
6080,cloud-initorboxery-provision.vm_copy's staging script includes a random 24-hex-digit id (.boxery-copy-<id>-destination), so roughly one run in 3,000 the id contains6080. The stub then "succeeds" for a VM that doesn't exist, and copy rightly rejects the empty reply as an unexpected staging response instead of reaching the "no such vm" path. Feeding the stub that call with a6080id reproduces it: exit 0 instead of 255. The failure appears once in the last 25 failed CI runs, and it predates the test reorganisation in #245.Fix. The stub now matches the three commands it actually stands in for, which I logged from a full run:
cloud-init status --wait, the noVNC readiness loop (127.0.0.1:6080/vnc.html) and the provisioning check (/var/log/boxery-provision.ok). None of them can appear in a hex id. Deleting the line isn't an option:new --headlessand thelschecks after it depend on it.Checks.
npm run lint,npm run typecheck,npm testandnpm run test:shellpass locally;controller-local.shalso passes under macOS/bin/bash3.2, and the stub now exits 255 for the6080id.This PR description was generated by Claude Code using Claude Opus 5.5