Repository navigation
fix(controller,host,core): remaining hints name --host; elapsed times use a monotonic clock - #247
Merged
Merged
Conversation
Hints the earlier fixes missed: - new/fork's outdated-guest warnings (#236) use the host's hint(), so `boxery --host lab new …` suggests `boxery --host lab patch NAME`. - Core messages for a VM that can't be reached (no such vm, stopped, pool lease) and the desktop errors use a new core cliHint(): --host NAME when the person gave one or the VM's host isn't the default, since a bare `boxery start NAME` goes to the default host. Shared with the agent tools. - jobs: hints use the invoked form; a missing job id is a usage error (2). - setup's pin note and capabilities' backends hint use hint(). secs() in new, fork and patch, and stop's wait, used Date.now(). A CI runner's clock stepping back a few ms printed "installed -1s after create" and failed host-output.sh intermittently; performance.now() is monotonic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d plain formatting) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #217 and #215, found while checking the merged fixes live on Lima, libvirt and exe.dev.
Hints that still dropped
--hostnew/fork's outdated-guest warnings (fix(host): new --headless reboots once if first boot asks; new warns when made from an outdated guest (#215) #236) saidboxery patch NAMEandboxery build-base. They use the host'shint()now, soboxery --host lab new …suggestsboxery --host lab patch NAME.cliHint():no such vm, a stopped VM, pool leases, the desktop errors,vm_info's outdated note, andno local lease. It names--host NAMEwhen the person gave one (BOXERY_CLI), or when the VM's host isn't the default (another host's VM incp, an agent's host session), since a bareboxery start NAMEgoes to the default host. A malformeddefault-hostfile doesn't replace the message.jobs: both hints use the invoked form. A missing job id is a usage error (exit 2, like a missing VM name). An invalid one still exits 1.setup's pin note andcapabilities' backends hint usehint().Timing flake
secs()innew,forkandpatch, andstop's wait loop, usedDate.now(). A CI runner's clock stepping back a few ms printedinstalled -1s after createand failedhost-output.sh"new --headless logs the layers it installs" on three PRs today. They useperformance.now()now, which is monotonic. Wall-clock uses that compare against file times or expiries are unchanged.Tests
controller-local.sh:--host local run nosuchnames--host.hosts.test.mjs: a non-default host via MCP names--host, also with a malformeddefault-host. Checked that this test fails without the guard.host-patch.sh:boxery-hostcalled directly saysboxery-host patch …; withBOXERY_CLI="boxery --host lab"it saysboxery --host lab patch ….cli-families.test.mjs: missing job id exits 2, invalid exits 1.Checks: lint, typecheck,
npm test(473),npm run test:shell,docs:cli(no diff), help-drift and backend-capabilities. Two load-sensitive tests failed once at a load average around 50: the cloud-hypervisor stop race and a copy timing test. Neither is touched here, and both passed when rerun alone.Review: an independent reviewer subagent read the diff and found no correctness issues. Applied: the
defaultHost()guard, pluscliHintinvm_info's outdated note andno local lease. Not changed: the upgrade hints informatVersions,versions.mjsandprofile.mjs. They take an explicit host that may not be the current one, and they already name--hostfor a non-default host.This PR description was generated by Claude Code using Claude Opus 5.5