add callback: mem_snapshot for profile#9411
Open
mugglewei97 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a MemorySnapshotCallback to record and visualize CUDA memory history at specified intervals during training, along with new configuration arguments mem_snapshot_path and mem_snapshot_interval. Review feedback suggests improving the implementation's robustness by validating that the snapshot interval is a positive integer to prevent division by zero errors, using os.path.splitext for safer file path manipulation, and ensuring the target directory exists before saving snapshots.
mugglewei97
force-pushed
the
feat/callback_mem_snapshot
branch
from
40c948e to
748dc52
Compare
mugglewei97
force-pushed
the
feat/callback_mem_snapshot
branch
from
748dc52 to
57df710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Add a new type of callback which help to profile memory occupation
Experiment results
Tested by myself it works