Repository navigation
fix(examples): keep standalone client checks out of pytest fixture discovery - #3815
Merged
Merged
Conversation
…scovery Preserve standalone protocol checks with executable loopback regressions. Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The standalone streaming client exposes three async
test_*helpers requiringexplicit server/audio arguments. Bare pytest mistakes these for fixture-based
tests and reports three
fixture 'server' not founderrors.Rename only the internal helpers and their callers to
check_*. Keep the CLIpath, arguments, protocol checks, PCM conversion and exit behavior unchanged.
No pytest ignore/skip configuration or assertion weakening is added.
Verification
protocol controls passed. After the fix, all 20 scoped tests pass, no skips.
with/without hotwords, exact PCM, short audio and consecutive sessions.
The peer supplies controlled protocol responses, not speech-model inference.
accidental helpers disappear and eight new executable regressions appear.
commit, resolved dependencies and JUnit artifacts.
Full-Suite Limitations
An isolated CPU/offline baseline run was interrupted after 83 passed, 9 model
hub connection failures, these 3 fixture errors and 1 missing-Sphinx skip.
The remainder did not execute. Full suite, pretrained ASR and GPU quality are
not claimed; those unavailable integrations are not rerun or hidden here.
No model/runtime behavior, weights, version, release or repository protection
changes. Nano optimization remains deferred.