Repository navigation
fix(realtime): validate and forward vLLM HF overrides - #3810
Merged
Merged
Conversation
Integrate #3768 with the preserved compatibility correction, object validation and durable CI. Co-authored-by: Li Junhui <lijunhui.me@foxmail.com> Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
4 of 9 tasks
Collaborator
Author
|
Normally merged with a verified signature and DCO. Final main matches the tested source tree. Both new-head and final-main NumPy matrices passed 358 cases each, with all 90 realtime and 13 new validation cases present, zero failures/skips, and actual downloaded artifacts/logs checked against exact source commits. CPU and synthetic native FP32/BF16 vLLM GPU scope and the retained failed fixture are detailed above. #3768 is closed as superseded with its author credited and fork untouched. This is a source fix, not a new release, pretrained ASR validation or Nano leaderboard work. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates @gotorion's #3768 on current main, with credit and the original fork/head untouched. The realtime CLI accepts
--hf-overridesJSON objects and forwards them to vLLM. The saved October compatibility correction keeps callers without the optional Namespace attribute working. Non-object JSON is rejected before model loading. The same regression tests now run in both existing NumPy CI matrices.Validation
7e47b3b731f30a7a4be1c21280f3eda57ab9767ec98894c71605869b9d554608). An intentionally unsupported architecture in the saved config is overridden by the parsed CLI object.