fix(subtitles): split overlong source cues - #3574
Merged
Merged
Conversation
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
PYTHONPATH=$PWD python -m pytest tests/test_cli.py tests/test_generate_subtitle.py -q-> 27 passedpython -m compileall -q funasr/cli.py examples/subtitle/generate_subtitle.py tests/test_cli.py7617b91b3ef8ce23b650a38a6a52b7c03f1e8f0f15b82ce5d8caabd55db286d1git diff --checkAddresses the overlong-cue boundary reported in #3539. The issue remains open until the reporter verifies the result on the affected mixed-language recording.