fix(client): treat *.localhost as loopback for OAuth token endpoints - #2597
Draft
arimu1 wants to merge 2 commits into
Draft
fix(client): treat *.localhost as loopback for OAuth token endpoints#2597arimu1 wants to merge 2 commits into
arimu1 wants to merge 2 commits into
Conversation
RFC 6761 §6.3 reserves names ending in .localhost as loopback. Exempt them from the SEP-2207 https token-endpoint guard (same as localhost / 127.0.0.1 / ::1) so host-based multi-tenant local dev works. Fixes modelcontextprotocol#2591
🦋 Changeset detectedLatest commit: a7f9b71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLoopbackHostso hostnames ending in.localhostare treated as loopback (RFC 6761 §6.3), in addition tolocalhost,127.0.0.1, and::1/[::1].assertSecureTokenEndpointallow plain-HTTP token endpoints on host-based multi-tenant local setups (e.g.http://tenant.example.localhost:3300/...) instead of throwingInsecureTokenEndpointError.application_typeinference for redirect URIs, so*.localhostredirects correctly default tonative.Fixes #2591
Motivation
.localhostis a reserved TLD: names under it resolve to loopback by specification (and by browsers / OS resolvers). The SDK’s https token-endpoint guard was stricter than that definition and blocked common local multi-tenant Host-header setups that cannot use barehttp://localhost.Test plan
packages/client/test/client/auth.test.ts:assertSecureTokenEndpointacceptstenant.example.localhostrefreshAuthorizationpermits*.localhosttoken endpointsresolveClientMetadataderivesapplication_type: 'native'for*.localhostredirects@modelcontextprotocol/clientpatchpnpm --filter @modelcontextprotocol/client test— 800/800 passedpnpm build:all/typecheck:all/lint:allgreenNotes
Straightforward bug fix + tests per CONTRIBUTING. Implementation assisted by tooling.
(Opened as draft due to API restriction converting to ready — please mark Ready for review if required.)