Add icons field support to registerTool() and registerToolTask()#1885
Open
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Add icons field support to registerTool() and registerToolTask()#1885Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
The MCP spec's ToolSchema includes icons via IconsSchema, but the high-level registerTool() and registerToolTask() APIs did not accept or pass through the icons field. This meant tools/list responses never included icons even when the spec supports them. Changes: - Add icons to RegisteredTool type and update() method - Add icons parameter to _createRegisteredTool() - Add icons to registerTool() and registerToolTask() config types - Include icons in toolDefinition for tools/list responses - Add test for tool registration with icons Fixes modelcontextprotocol#1864
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1864
The MCP spec
sToolSchemaincludesiconsviaIconsSchema, but the high-levelregisterTool()andregisterToolTask()APIs did not accept or pass through theiconsfield. This meanttools/list` responses never included icons even when the spec supports them.Changes
iconstoRegisteredTooltype andupdate()methodiconsparameter to_createRegisteredTool()iconstoregisterTool()andregisterToolTask()config typesiconsintoolDefinitionfortools/listresponsesTest plan
pnpm typecheck:all)registerTool()config and included intools/listresponse