Skip to content

Reject standalone GET in stateless streamable HTTP mode #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vrv wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

Reject standalone GET in stateless streamable HTTP mode #1884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/server/src/server/streamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,17 @@ export class WebStandardStreamableHTTPServerTransport implements Transport {
* Handles `GET` requests for SSE stream
*/
private async handleGetRequest(req: Request): Promise<Response> {
// Stateless transports cannot safely own a standalone GET SSE stream.
// In stateless mode, each HTTP request must use a fresh transport
// instance, so allowing GET here would create transport-local stream
// state with no durable owner across requests.
if (this.sessionIdGenerator === undefined) {
return this.createJsonErrorResponse(405, -32_000, 'Method not allowed.', {
headers: {
Allow: 'POST'
}
});
}
// The client MUST include an Accept header, listing text/event-stream as a supported content type.
const acceptHeader = req.headers.get('accept');
if (!acceptHeader?.includes('text/event-stream')) {
Expand Down
Loading