Repository navigation
ci: add mcp-interface-diff.yml as a dispatch-only placeholder (staged rename, Step 1) - #5528
Conversation
Step 1 of the staged rename of everything-mcp-diff.yml (#5463). GitHub dispatches a workflow only when its file exists on the default branch, and the version workflows dispatch the diff by file name from v2/main, so the new name ships to main first as a placeholder with only a workflow_dispatch trigger. #5527 then moves the diff into it and switches the callers. A test pins that the placeholder is dispatch-only and that no version workflow dispatches it yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
|
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 1 | 1 | 0 | 0 |
| Head | 1 | 1 | 0 | 0 |
Updated by this run for bc9d1e6273f92d4c0d2ce8476848df2e3ec10ace.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 9 | 0 | 1 | 0 |
| Head | 9 | 0 | 1 | 0 |
Updated by this run for bc9d1e6273f92d4c0d2ce8476848df2e3ec10ace.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 3 | 0 | 0 | 0 |
| Head | 3 | 0 | 0 | 0 |
Updated by this run for bc9d1e6273f92d4c0d2ce8476848df2e3ec10ace.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 14 | 2 | 0 | 0 |
| Head | 14 | 2 | 0 | 0 |
Updated by this run for bc9d1e6273f92d4c0d2ce8476848df2e3ec10ace.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 22 | 4 | 8 | 5 |
| Head | 22 | 4 | 8 | 5 |
Updated by this run for bc9d1e6273f92d4c0d2ce8476848df2e3ec10ace.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 16 | 0 | 0 | 1 |
| Head | 16 | 0 | 0 | 1 |
Updated by this run for bc9d1e6273f92d4c0d2ce8476848df2e3ec10ace.
|
| Tools | Prompts | Resources | Resource templates | |
|---|---|---|---|---|
| Base | 1 | 0 | 0 | 0 |
| Head | 1 | 0 | 0 | 0 |
Updated by this run for bc9d1e6273f92d4c0d2ce8476848df2e3ec10ace.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the staged workflow rename.
No open issues 🎉
What changed in this PR
Stages the MCP interface-diff workflow rename by adding the future filename before it reaches main. Existing dispatch callers remain unchanged until Step 2 (#5527), avoiding a gap in version-PR checks.
Changes:
- Adds a dispatch-only placeholder that points to the existing workflow without duplicating automatic runs.
- Adds a regression test ensuring the placeholder stays dispatch-only and version workflows do not target it yet.
- Documents the staged transition in workflow comments and the repository tree.
| File | Description |
|---|---|
scripts/version-pr-ci.test.mjs |
Pins the placeholder’s trigger and unchanged dispatch callers. |
AGENTS.md |
Lists the new placeholder in the workflows tree. |
.github/workflows/mcp-interface-diff.yml |
Adds the future workflow filename with a message-only manual job. |
.github/workflows/everything-mcp-diff.yml |
Updates header comments to explain the staged rename; no behavior change. |
Review effort: Balanced
|
Copilot round 1: clean (no findings, no suppressed comments). The review loop has converged on its first round; no further rounds requested. |
Closes #5463
Description
Step 1 of renaming
.github/workflows/everything-mcp-diff.ymltomcp-interface-diff.yml, staged across a milestone merge..github/workflows/mcp-interface-diff.yml: a placeholder with only aworkflow_dispatchtrigger and one job that says where the diff runs. It never runs onpushorpull_request, so it cannot run beside the real diff.scripts/version-pr-ci.test.mjs: a test pinning that the placeholder is dispatch-only and that neither version workflow dispatches it yet.everything-mcp-diff.yml: its header now says the rename is staged and points to CI: rename everything-mcp-diff.yml to mcp-interface-diff.yml, staged across a milestone merge [Step 1] #5463 / CI: rename everything-mcp-diff.yml to mcp-interface-diff.yml, staged across a milestone merge [Step 2] #5527. No behavior change.AGENTS.md: the workflows tree lists the new file.The callers (
version-packages.yml,prepare-python-release.yml,RELEASING.md, thereleaseskill,scripts/lib/interface-diff-servers.mjs) are unchanged; #5527 (Step 2) switches them after this reachesmain.Server Details
AGENTS.mdMotivation and Context
GitHub dispatches a workflow only when its file exists on the default branch (
main), and both version workflows dispatch the diff by file name fromv2/main. A one-step rename onv2/mainwould break their dispatch until the next milestone merge. Getting the new name ontomainfirst lets Step 2 rename with no gap.Why a placeholder rather than a full copy (the issue offered a copy as one example): a
workflow_dispatchcall resolves the file name onmainbut runs the file as it is on the dispatched ref. So a placeholder onmainmakesmcp-interface-diff.ymldispatchable exactly as well as a copy would, and there is no second 400-line copy to keep in sync witheverything-mcp-diff.ymluntil Step 2. Step 2 moves the real contents into this file.How Has This Been Tested?
No client-observable surface (CI only), so targeted probes:
npm run local:gateexits 0.node --test scripts/version-pr-ci.test.mjs→✔ mcp-interface-diff.yml is a dispatch-only placeholder until Step 2.pull_request:to the placeholder'son:fails that test (deepEqualon the trigger list); reverting makes it pass again.git show origin/main:.github/workflows/mcp-interface-diff.ymlfails today, which confirms the name is not onmainyet and this step is needed.workflow-gateguard (every job declarestimeout-minutes) passes on the new file inside the gate.Breaking Changes
None.
Types of changes
(CI-only chore; none of the above apply.)
Checklist
contents: readonly and runs no repository code)AGENTS.mdtree is updated)npm run changeset) if this changes what a TypeScript server publishes (not applicable: nothing published changes)Additional context
Next: once this ships to
mainin the v2.5.0 milestone merge, #5527 does Step 2.🤖 Generated with Claude Code