fix(everything): label blob resources as application/octet-stream - #4767
Open
simpleqt wants to merge 1 commit into
Open
fix(everything): label blob resources as application/octet-stream#4767simpleqt wants to merge 1 commit into
simpleqt wants to merge 1 commit into
Conversation
blobResource() returned mimeType text/plain (copy-paste from textResource), so every generated blob resource_link was described as a 'plaintext resource' while carrying base64 content; the registered template already declares application/octet-stream (line 195). The now-redundant conditional in get-resource-links was collapsed accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blobResource()insrc/everything/resources/templates.tsreturnedmimeType: "text/plain"— a copy-paste fromtextResource()— while carrying base64 content, and while the registered blob resource template (line 195) declaresapplication/octet-stream. Downstream,get-resource-links.tsdescribed every blobresource_linkas a "plaintext resource" for the same reason.Changed the mime type to
application/octet-streamand collapsed the now-always-false conditional in the link description.Testing
__tests__/tools.test.tspins the odd/even blob-text naming split but does not assert mimeType, so no test changes are needed; vitest should stay green.