fix: declare zod runtime deps for TS servers#4291
Open
xianzuyang9-blip wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
src/filesystem/index.ts, src/memory/index.ts, and src/sequentialthinking/index.ts all import zod directly. Without a direct package dependency, strict package managers can omit a co-located zod install for these published packages and the server entrypoints can fail with ERR_MODULE_NOT_FOUND.
Verification
pm install --package-lock-only --ignore-scripts
pm install --ignore-scripts
pm run build -w src/sequentialthinking
pm run build -w src/memory
pm run build -w src/filesystem
pm run test -w src/sequentialthinking (14 passed)
pm run test -w src/memory (45 passed)
pm run test -w src/filesystem (147 passed; symlink-only cases skipped by test suite on Windows)
Fixes #4288