fix(filesystem): only apply MCP roots when no CLI directories are provided#4014
Open
Will-hxw wants to merge 4 commits intomodelcontextprotocol:mainfrom
Open
fix(filesystem): only apply MCP roots when no CLI directories are provided#4014Will-hxw wants to merge 4 commits intomodelcontextprotocol:mainfrom
Will-hxw wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
The resourceType argument in the resource-prompt was missing a description of allowed values. Added "must be 'Text' or 'Blob'" to help automated callers understand the expected input format. Issue: modelcontextprotocol#3985 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Prevent leaking all process.env variables by requiring a specific key. This addresses a security concern where the tool was returning the entire environment without any parameter or filtering. Issue: modelcontextprotocol#3986 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
When a client supports MCP roots, the server was unconditionally replacing CLI-provided allowed directories with the client's roots. This made it impossible to scope the server to a directory outside the client's project root. Now CLI arguments take precedence - only fetch and apply MCP roots when no CLI directories were provided. Fixes: modelcontextprotocol#3929 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The roots/list_changed handler was unconditionally replacing allowedDirectories with MCP roots, even when CLI directories were set. Adding the same guard as oninitialized to prevent MCP roots from overriding CLI directories when both are present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #3929: When clientCapabilities.roots is true, the server unconditionally replaces CLI-specified directories with client roots, preventing the server from being limited to directories outside the client project root.
Validation