fix(filesystem): prevent MCP roots from overriding CLI-provided directories#3994
Open
Will-hxw wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix(filesystem): prevent MCP roots from overriding CLI-provided directories#3994Will-hxw wants to merge 2 commits intomodelcontextprotocol:mainfrom
Will-hxw wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
The has_changes() function only considered .py and .ts files when deciding whether to bump a package version. This caused packages with only lockfile changes (e.g., uv.lock from dependabot) to be skipped during release. Fixes Issue modelcontextprotocol#3870
…tories When a client sends MCP roots, the server should not override explicitly CLI-provided directories. This fixes the issue where users could not scope the filesystem server to a directory outside the client's project root. If CLI directories are explicitly provided, they take precedence over MCP roots protocol. Fixes Issue modelcontextprotocol#3929
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateAllowedDirectoriesFromRootsto skip overriding if CLI directories were explicitly providedWhy
Previously, MCP roots would unconditionally replace
allowedDirectorieseven when the user explicitly provided directories via CLI args. This made it impossible to scope the server to a directory outside the client's project root.Validation
hasCliDirectoriesis true, the function returns early without overridingRelated
Fixes Issue #3929