feat(filesystem): add --ignore-write option to block writes to sensit…#1901
feat(filesystem): add --ignore-write option to block writes to sensit…#1901SOURABHMISHRA5221 wants to merge 15 commits intomodelcontextprotocol:mainfrom
Conversation
|
Hi @tadasant |
|
Hi! @olaservo please review. |
|
Hi @olaservo... Do you think we need to change something in this? |
Hi @SOURABHMISHRA5221 ! Thanks for the ping and sorry for the wait. I've started reviewing this and other filesystem PRs that relate to file exclusion patterns and restrictions, since there are a few out there, and we've also been doing some security hardening on this server. I expect to leave feedback on these soon, but if you don't hear back next week feel free to @ me again. We had a huge backlog of Readme updates that were adding some noise to mentions but I will keep an eye out. Thanks! |
|
Hi @olaservo!... Hope you're doing well. Just wanted to follow up on the PR review when you get a chance. |
|
Closing this PR — it has merge conflicts due to the major architecture refactoring (Nov 2025) and would need a full rewrite for the current Apologies for the long delay in getting back to you on this — I acknowledged your pings in July and then got pulled into other work. That's on me. The feature request (issue #1869) is still valid, but there are some design considerations for a fresh implementation:
Thank you for the contribution and your patience — the underlying need to protect sensitive files is real and we'll keep issue #1869 open. This comment was posted by Claude Code on behalf of @olaservo. |
Title:
feat(filesystem): add --ignore-write option to block writes to sensitive files (#1869)
Description:
This PR addresses issue #1869 by adding a flexible mechanism to prevent accidental overwrites of sensitive files (such as
.env) in the Filesystem MCP server.Summary of changes:
--ignore-write <pattern1> <pattern2> ...command-line argument to the filesystem server..env,.env.*,*.secret, etc.), even if the file is within an allowed directory.Motivation:
Previously, the server could overwrite sensitive files (e.g.,
.env) without confirmation, risking data loss. This change allows users to specify which files should never be overwritten, improving safety and flexibility.Testing:
Documentation:
--ignore-writeoption.Checklist: