fix(schema): remove AddNullable from draft2020_12 settings#664
Open
mwotton wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(schema): remove AddNullable from draft2020_12 settings#664mwotton wants to merge 1 commit intomodelcontextprotocol:mainfrom
mwotton wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
The `nullable` keyword is an OpenAPI 3.0 extension, not part of
JSON Schema 2020-12. Using AddNullable with draft2020_12 settings
causes validation failures with strict JSON Schema validators.
JSON Schema 2020-12 represents nullable types using:
- {"type": ["string", "null"]} (type array with null)
- {"anyOf": [{"type": "string"}, {"type": "null"}]}
Fixes modelcontextprotocol#663
github-actions
bot
added
T-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
schema_for_type()function usesAddNullable::default()as a transform when generating JSON Schema 2020-12 schemas. However, thenullablekeyword is an OpenAPI 3.0 extension, not part of JSON Schema 2020-12. This causes validation failures with strict JSON Schema validators.Solution
Remove the
AddNullabletransform from the draft2020_12 settings. JSON Schema 2020-12 represents nullable types using:{"type": ["string", "null"]}(type array with null){"anyOf": [{"type": "string"}, {"type": "null"}]}Before
An optional string field produced:
{ "nullable": true, "type": "string" }After
An optional string field produces:
{ "type": ["string", "null"] }Fixes #663