fix: duplicate meta serialization#662
Open
DaleSeo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: duplicate meta serialization#662DaleSeo wants to merge 1 commit intomodelcontextprotocol:mainfrom
DaleSeo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #647
Motivation and Context
PR #617 (SEP-1319) added
_metafields to params structs, butWithMetaalready injects_metafrom extensions via#[serde(flatten)]. When both are populated, the serialized JSON contains duplicate_metakeys, which is invalid.This PR replaces the derived
SerializeonWithMetawith a manual implementation that extracts_metafrom the flattened params, merges it with extensions_meta, and emits a single key. The fix is centralized in one place and covers all affected types. On conflict, extensions-level values take priority. No API changes; deserialization is unchanged.How Has This Been Tested?
Add unit tests to verify the new behavior and prevent any regression.
Breaking Changes
None.
Types of changes
Checklist
Additional context