Repository navigation
Read the wire _meta member back through JSON in the Skills server test - #642
Merged
koic merged 1 commit intoOct 30, 2026
Conversation
## Motivation and Context
The test that checks `skills/list` and `skills/get` emit a skill's `_meta` under that key sliced the generated
JSON with the regexp `/"_meta":\{[^}]*\}/`. CodeQL flags the pattern as polynomial on a crafted subject
(code scanning alert 14): on a subject that repeats `"_meta":{` without a closing brace, the unanchored match
restarts at every occurrence and `[^}]*` scans to the end before `\}` fails, so the work grows with the square
of the length. The subject here is the server's own output, so nothing untrusted reaches the regexp, but the test
needs no regexp at all: parsing the generated JSON back and reading `"_meta"` checks the same thing, the key
the wire carries, without a pattern a scanner has to reason about.
## How Has This Been Tested?
test/mcp/server_skills_test.rb; the test still fails when `Skill#to_h` emits the member under another key.
## Breaking Changes
None.
koic
deleted the
read_the_wire_meta_member_back_through_json_in_the_skills_test
branch
October 30, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The test that checks
skills/listandskills/getemit a skill's_metaunder that key sliced the generated JSON with the regexp/"_meta":\{[^}]*\}/. CodeQL flags the pattern as polynomial on a crafted subject (code scanning alert 14): on a subject that repeats"_meta":{without a closing brace, the unanchored match restarts at every occurrence and[^}]*scans to the end before\}fails, so the work grows with the square of the length. The subject here is the server's own output, so nothing untrusted reaches the regexp, but the test needs no regexp at all: parsing the generated JSON back and reading"_meta"checks the same thing, the key the wire carries, without a pattern a scanner has to reason about.How Has This Been Tested?
test/mcp/server_skills_test.rb; the test still fails when
Skill#to_hemits the member under another key.Breaking Changes
None.
Types of changes
Checklist