Enable RuboCop on CI#25
Merged
atesgoral merged 1 commit intomodelcontextprotocol:mainfrom May 30, 2025
Merged
Conversation
andyw8
reviewed
May 27, 2025
koic
force-pushed
the
enable_rubocop_on_ci
branch
from
1fa8f72 to
eb0fec4
Compare
When running `bundle exec rake` in the local environment, RuboCop is executed, but it was not included in the CI workflow. This PR enables RuboCop execution in the CI workflow. RuboCop performs static analysis on the source code using Ruby 3.2, in accordance with the gemspec setting `spec.required_ruby_version = ">= 3.2.0"`: https://github.com/modelcontextprotocol/ruby-sdk/blob/6b49222edb8709821a58bbe39cb85fd5409882eb/model_context_protocol.gemspec#L16 In other words, it is not necessary to run RuboCop under every Ruby version from 3.2 to head, so it is defined as a separate job from the test job.
koic
force-pushed
the
enable_rubocop_on_ci
branch
from
eb0fec4 to
3477406
Compare
atesgoral
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When running
bundle exec rakein the local environment, RuboCop is executed, but it was not included in the CI workflow.This PR enables RuboCop execution in the CI workflow. RuboCop performs static analysis on the source code using Ruby 3.2, in accordance with the gemspec setting
spec.required_ruby_version = ">= 3.2.0":ruby-sdk/model_context_protocol.gemspec
Line 16 in 6b49222
In other words, it is not necessary to run RuboCop under every Ruby version from 3.2 to head, so it is defined as a separate job from the test job.
Types of changes
Checklist