Fix Prompt#validate_arguments! crash when arguments are nil#246
Open
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix Prompt#validate_arguments! crash when arguments are nil#246koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Prompt#validate_arguments! crash when arguments are nil#246koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
`Prompt#validate_arguments!` called `required_args` which does `arguments_value.filter_map`, crashing with `NoMethodError` when `arguments_value` is `nil` (the default for prompts without declared arguments). Additionally, passing `nil` as args caused a crash on `args.keys`. Fix by defaulting `arguments_value` to `[]` and guarding against `nil` args.
koic
force-pushed
the
fix_prompt_nil_arguments
branch
from
7cd355d to
3d84eab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Prompt#validate_arguments!calledrequired_argswhich doesarguments_value.filter_map, crashing withNoMethodErrorwhenarguments_valueisnil(the default for prompts without declared arguments). Additionally, passingnilas args caused a crash onargs.keys.Fix by defaulting
arguments_valueto[]and guarding againstnilargs.How Has This Been Tested?
Added a repro test to verify the fix and prevent regression.
Breaking Changes
None.
Types of changes
Checklist