Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mcp/server/transports/streamable_http_transport.rb
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def get_session_stream(session_id)
def send_response_to_stream(stream, response, session_id)
message = JSON.parse(response)
send_to_stream(stream, message)
[200, { "Content-Type" => "application/json" }, [{ accepted: true }.to_json]]
handle_accepted
rescue IOError, Errno::EPIPE => e
MCP.configuration.exception_reporter.call(
e,
Expand Down
41 changes: 41 additions & 0 deletions test/mcp/server/transports/streamable_http_transport_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,47 @@ class StreamableHTTPTransportTest < ActiveSupport::TestCase
assert_nil(body)
end

test "send_response_to_stream returns 202 when message is sent to stream" do
# Create and initialize a session
init_request = create_rack_request(
"POST",
"/",
{ "CONTENT_TYPE" => "application/json" },
{ jsonrpc: "2.0", method: "initialize", id: "123" }.to_json,
)
init_response = @transport.handle_request(init_request)
session_id = init_response[1]["Mcp-Session-Id"]

# Connect with SSE
io = StringIO.new
get_request = create_rack_request(
"GET",
"/",
{ "HTTP_MCP_SESSION_ID" => session_id },
)
response = @transport.handle_request(get_request)
response[2].call(io) if response[2].is_a?(Proc)

# Give the stream time to set up
sleep(0.1)

# Make a regular request that will be routed through send_response_to_stream
request = create_rack_request(
"POST",
"/",
{
"CONTENT_TYPE" => "application/json",
"HTTP_MCP_SESSION_ID" => session_id,
},
{ jsonrpc: "2.0", method: "ping", id: "456" }.to_json,
)

response = @transport.handle_request(request)
assert_equal 202, response[0]
assert_empty response[1]
assert_empty response[2]
end

test "handle post request with a standard error" do
request = create_rack_request(
"POST",
Expand Down