Support Sorbet typed tools#10
Merged
atesgoral merged 2 commits intomodelcontextprotocol:mainfrom May 27, 2025
Merged
Conversation
chrisbutcher
force-pushed
the
fix-sorbet-runtime-compatibility
branch
from
89a8eb7 to
3986fb9
Compare
st0012
reviewed
May 16, 2025
chrisbutcher
force-pushed
the
fix-sorbet-runtime-compatibility
branch
from
3986fb9 to
31dd08e
Compare
chrisbutcher
force-pushed
the
fix-sorbet-runtime-compatibility
branch
2 times, most recently
from
337631f to
7e33e76
Compare
topherbullock
added a commit
that referenced
this pull request
May 20, 2025
ci on #10 is failing due to darwin deps in the lockfile. fix ci by removing the gemfile and adding `bundle install` to ci steps
chrisbutcher
force-pushed
the
fix-sorbet-runtime-compatibility
branch
from
7e33e76 to
884acfe
Compare
chrisbutcher
force-pushed
the
fix-sorbet-runtime-compatibility
branch
from
884acfe to
6e78209
Compare
Contributor
Author
|
cc: @topherbullock CI is 🟢 |
atesgoral
approved these changes
May 24, 2025
topherbullock
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #9
How Has This Been Tested?
Second commit updates tools defined in tool_test.rb unit tests use the expected kwarg syntax.
Breaking Changes
None.
Types of changes
Checklist