Skip to content

fix(client): preserve OAuth endpoint query params#2829

Open
he-yufeng wants to merge 2 commits into
modelcontextprotocol:mainfrom
he-yufeng:fix/oauth-query-endpoint
Open

fix(client): preserve OAuth endpoint query params#2829
he-yufeng wants to merge 2 commits into
modelcontextprotocol:mainfrom
he-yufeng:fix/oauth-query-endpoint

Conversation

@he-yufeng

Copy link
Copy Markdown

Summary

Fixes #2776.

To verify

  • uv run --frozen pytest tests/client/test_auth.py::TestOAuthFallback::test_authorization_endpoint_preserves_existing_query_params -q
  • uv run --frozen pytest tests/client/test_auth.py -q
  • uv run --frozen pyright src/mcp/client/auth/oauth2.py tests/client/test_auth.py
  • uv run --frozen ruff check src/mcp/client/auth/oauth2.py tests/client/test_auth.py
  • git diff --check

@he-yufeng

Copy link
Copy Markdown
Author

This is the kept OAuth endpoint query-parameter branch after closing the older duplicate #2787.

The current check matrix is green across pre-commit, conformance, readme snippets, and Python 3.10-3.14 on Ubuntu/Windows.

Could a maintainer review when convenient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAuth handler doesn't support redirect URLs with params

1 participant