fix: normalize empty tool schema properties - #411
Open
Hanshuk wants to merge 4 commits into
Open
Conversation
Hanshuk
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
August 10, 2026 19:28
Hanshuk
marked this pull request as draft
August 10, 2026 19:38
Hanshuk
marked this pull request as ready for review
August 10, 2026 19:55
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #405.
PHP serializes empty arrays as
[], which causes an empty JSON Schemapropertiesobject to be serialized as an array instead of the required JSON object{}.This can cause strict MCP clients to reject otherwise valid tool definitions.
Changes
propertiesarrays to\stdClass.Tool::jsonSerialize()so directly constructedToolinstances are handled correctly despite readonly schema properties.inputSchemaandoutputSchema.requiredandenum.Tool::fromArray()normalization behavior.Test coverage
Added regression coverage for:
Toolconstruction with emptyproperties.Tool::fromArray()with emptyproperties.properties.requiredandenumarrays.outputSchemawith emptyproperties.Validation
git diff --checkpasses.The implementation is intentionally limited to the schema normalization and regression tests required for #405.