[Capability] Preserve optional content fields in PromptResultFormatter - #406
Open
chr-hertel wants to merge 2 commits into
Open
[Capability] Preserve optional content fields in PromptResultFormatter#406chr-hertel wants to merge 2 commits into
chr-hertel wants to merge 2 commits into
Conversation
The formatter's typed-content path rebuilt each Content object from only its required fields, silently dropping everything else a prompt returned (annotations on every type, _meta and explicit mimeType on embedded resource contents). Delegate to the schema classes' fromArray() instead, keeping the historical mimeType defaulting and RuntimeException-with- index error contract. ImageContent was the only content class without annotations support, so it gains the same constructor/fromArray()/jsonSerialize() handling as TextContent and AudioContent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
July 27, 2026 16:19
chr-hertel
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves optional typed-content fields when formatting prompt results and adds annotation support to images.
Changes:
- Delegates typed-array conversion to schema classes.
- Adds
ImageContentannotations and serialization. - Adds regression tests and changelog entries.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Capability/Formatter/PromptResultFormatter.php |
Preserves optional content fields during formatting. |
src/Schema/Content/ImageContent.php |
Adds image annotations support. |
tests/Unit/Capability/Formatter/PromptResultFormatterTest.php |
Tests field preservation and errors. |
tests/Unit/Schema/Content/ImageContentTest.php |
Tests image annotation behavior. |
CHANGELOG.md |
Documents the changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PromptResultFormatter rebuilt typed content arrays from only their required fields, silently dropping
annotations(all types) and_meta/explicitmimeType(embedded resources). It now delegates to the schema classes'fromArray(), keeping the historical mimeType defaulting and error contract. Also addsannotationssupport toImageContentfor parity with the other content types.Noticed while reviewing #400
🤖 Generated with Claude Code