[Server] Throw the SDK's own RuntimeException from FileSessionStore - #404
Open
chr-hertel wants to merge 1 commit into
Open
Conversation
The constructor guarded its unwritable-directory case with the global `\RuntimeException`, the only throw in `src/` still outside `Mcp\Exception\ExceptionInterface`. A consumer wrapping server setup in a `catch (ExceptionInterface)` missed it and got an unhandled SPL exception on a misconfigured session directory instead. `Mcp\Exception\RuntimeException` extends `\RuntimeException`, so this is additive: existing `catch (\RuntimeException)` blocks keep working. The constructor had no test coverage at all, so this adds one for the throw plus the directory-creation and write/read paths around it.
chr-hertel
added
the
enhancement
chr-hertel
marked this pull request as ready for review
July 27, 2026 14:38
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
July 27, 2026 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSessionStore::__construct()threw the global\RuntimeExceptionfor an unwritable session directory — the last throw insrc/outsideMcp\Exception\ExceptionInterface, socatch (ExceptionInterface)missed it.Mcp\Exception\RuntimeExceptionextends\RuntimeException, so the change is additive: existingcatch (\RuntimeException)blocks keep working. (ConfigurationExceptionwould read better but extendsInvalidArgumentException, which would break them.)The constructor had no coverage, so
FileSessionStoreTestis new — the throw, plus the directory-creation and write/read paths beside it.Spotted while reviewing #403, but unrelated to it and older, hence split out.