Skip to content

fix(server): replay late initialization callbacks - #938

Open
mikemikimike wants to merge 1 commit into
modelcontextprotocol:mainfrom
mikemikimike:fix/920-server-session-init-replay
Open

fix(server): replay late initialization callbacks#938
mikemikimike wants to merge 1 commit into
modelcontextprotocol:mainfrom
mikemikimike:fix/920-server-session-init-replay

Conversation

@mikemikimike

Copy link
Copy Markdown

Summary

  • Replay ServerSession.onInitialized callbacks registered after notifications/initialized.
  • Preserve registration order for callbacks registered before initialization and make the state transition race-safe.
  • Add a handshake-level regression test and document synchronous replay behavior.

Fixes #920

Validation

  • :integration-test:jvmTest --tests "io.modelcontextprotocol.kotlin.sdk.server.ServerSessionInitializeTest" — passed
  • :kotlin-sdk-server:jvmTest — passed
  • :kotlin-sdk-server:ktlintCheck :integration-test:ktlintCheck — passed
  • :kotlin-sdk-server:detekt :integration-test:detekt — passed
  • :kotlin-sdk-server:jvmApiCheck — passed
  • git diff --check — passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ServerSession.onInitialized has no state replay, so late registrants silently miss the event

1 participant