Pass request builder to constructor to support custom headers #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithin-pullela-aws
approved these changes
Mar 31, 2025
Contributor
|
Thank you @renxiawang ! will review it shortly |
tzolov
pushed a commit
that referenced
this pull request
Apr 6, 2025
Enhances FlowSseClient and HttpClientSseClientTransport to accept a custom HttpRequest.Builder, allowing for greater flexibility when configuring HTTP requests. This enables clients to customize headers, timeouts, and other request properties across all SSE connections and message sending operations. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Contributor
|
Thanks @renxiawang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for custom request headers for SSE transport
Motivation and Context
Close #68
How Has This Been Tested?
This change simply injects a HttpRequest.Builder to HttpClientSseClientTransport. Existing HttpClientSseClientTransportTests passed. I considered adding a test to mock the http client and verify a request is sent with custom headers within the unit, but it seems testing too much of the internal logic of the unit, not the input/output behavior. Let me know what you think.
Breaking Changes
No.
Types of changes
Checklist
Additional context