[cliffhall]

Closes #2967

Problem

While a sampling or elicitation request is open in PendingRequestModal, the tool, resource and prompt test modals gated their own useInput, but the ink-form <Form> underneath was not gated. ink-form exposes no isActive: every field, the section tabs and the arrow-key focus moves are its own useInput/useFocus hooks, and Ink's focus manager is shared with the overlay's form. Keys typed into the overlay therefore also moved focus and could edit values in the hidden form.

Change

• New clients/tui/src/components/GatedForm.tsx. It wraps ink-form's <Form> with an active prop. Ink cannot mask stdin for a subtree, so "inert" means "not mounted": while active is false the <Form> is not rendered, so none of its handlers or focusables exist. The draft survives because the form runs in ink-form's controlled mode, with its value held in GatedForm, which stays mounted. The value is seeded from each field's initialValue, which is what the uncontrolled form did on mount, so a submit carries the same defaults as before.
• ToolTestModal, ResourceTestModal, PromptTestModal render GatedForm active={inputActive}. Their if (!inputActive) return; submit guards are removed: a form that is not mounted cannot submit.
• RootsModal gets the same treatment. Its add-root form had the identical gap and the identical "ink-form still sees its keys" guard, so leaving it out would leave the same bug in a fourth place.

One limit, stated in the component header: ink-form's own view state is not kept across the toggle. That covers which tab and field had focus, and an edit still open in a field (not yet committed with Enter), which is discarded the way Esc discards it. Committed values, which are everything a submit sends, are kept exactly.

Tests

clients/tui/__tests__/GatedForm.test.tsx runs the real ink-form, not the double the modal suites use, because the bug lives in ink-form's own handlers:

• defaults are submitted as before;
• with a committed edit in place, the gated form shows a paused line and ignores focus moves, edit/commit keys and a submit; when it is re-activated the draft is exactly as left, and the next submit sends it.

I checked that the second test fails against a variant that keeps <Form> mounted while gated: the gated keys submit the hidden form. The existing modal suites' inputActive={false} cases (Enter does not submit) still pass.

Screenshots

Captured from the built TUI in a pseudoterminal against a scratch stdio server. The server has a book_trip(city, note) tool and sends an elicitation unprompted a few seconds after connecting, which is the trigger the issue describes. The same key script was used for every shot: fill the form, wait for the request, then in the overlay press ↓ Enter 14A Enter (fill Seat) and ↓ Enter (Submit).

After: draft filled before the request arrives

After: request open above the form

After: Seat filled in the overlay

After: ↓ Enter submitted the request and the form returns with its draft intact

Before (origin/v2/main), same keys: ↓ Enter never reaches the overlay's Submit. Focus left the overlay for the hidden form's fields, so no field and no button in the overlay is highlighted, and the request stays open.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

Form defaults for __proto__ arguments are not preserved because assignment to a plain object invokes its prototype setter instead of creating an own property, causing those values to be lost during serialization and decoding.

1 open issue

• Preserve proto defaults as own form values · New

What changed in this PR

This PR addresses #2967 by preventing underlying TUI forms from receiving keyboard input while a sampling or elicitation request overlay is open.

Changes:

• Adds GatedForm, which unmounts inactive forms while preserving committed values; focus and uncommitted edits are not retained.
• Applies the wrapper to tool, resource, prompt, and roots forms.
• Adds real ink-form tests for defaults, inactive input handling, and draft restoration.

File	Description
clients/​tui/​src/​components/​ToolTestModal.tsx	Gates the tool argument form through GatedForm.
clients/​tui/​src/​components/​RootsModal.tsx	Gates the add-root form during pending requests.
clients/​tui/​src/​components/​ResourceTestModal.tsx	Gates the resource template form.
clients/​tui/​src/​components/​PromptTestModal.tsx	Gates the prompt argument form.
clients/​tui/​src/​components/​GatedForm.tsx	Adds controlled draft storage and conditional form mounting.
clients/​tui/​__tests__/​GatedForm.test.tsx	Tests defaults, input isolation, and committed draft preservation.

_{Review effort: Balanced}

[cliffhall]

Copilot round 1: 1 finding, fixed.

• __proto__ defaults were not kept as own values in initialFormValues. Fixed in c5dbafd by switching to Object.fromEntries, with a test.

[Copilot]

🟢 Approval recommended

No active review issues are reported for the change that prevents hidden TUI forms from receiving keystrokes while request overlays are open.

No open issues 🎉

1 resolved since last review

• Preserve proto defaults as own form values

_{Review effort: Balanced}

[cliffhall]

Copilot review loop closed. Round 2 was clean, with no inline comments, no headline findings and no suppressed comments. That is the clean-round exit, after 2 rounds.