Skip to content

Add a v1 npm deprecate step to the release skill - #2968

Merged
cliffhall merged 2 commits into
v2/mainfrom
v2/docs/2954-release-v1-deprecate-step
Nov 12, 2026
Merged

cliffhall merged 2 commits into
v2/mainfrom
v2/docs/2954-release-v1-deprecate-step

Conversation

@cliffhall

Copy link
Copy Markdown
Member

Closes #2954

Adds v1-6. Deprecate the version just published to the release skill's v1 flow, after v1-5 (Verify). The old v1-6 (release notes for unpublished advisories) becomes v1-7; nothing outside the skill referenced the step numbers.

The new step covers each acceptance criterion:

  • Exact version, all four packages: @modelcontextprotocol/{inspector,inspector-cli,inspector-client,inspector-server}@X.Y.Z.
  • Never a range: <2.0.0 matches 2.0.0-rc.1/2/3; the safe spelling is <2.0.0-0.
  • The message: read back with npm view …@<PREVIOUS> deprecated, and stated verbatim (checked against 1.0.3 on npm).
  • An empty message lifts deprecation: warned, with the verification framed as mandatory for that reason.
  • Maintainer-run: 2FA/EOTP; an agent stops and hands over the four commands (! npm deprecate … --otp=<code>); fresh TOTP codes per command.
  • Verify: npm view … deprecated --prefer-online for all four, plus a check that 2.0.0-rc.1..3 and latest stay un-deprecated.

v1-1 also now says to list the deprecate step in the v1 release issue's checklist, per the issue's optional suggestion.

Only the skill body changed. release is disable-model-invocation: true and its description is untouched, so no skills:eval re-run is needed. npm run verify:skills and npm run local:gate pass.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
@cliffhall cliffhall added the v2 Issues and PRs for v2 label Nov 12, 2026
@cliffhall
cliffhall requested a balanced review from Copilot November 12, 2026 05:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The handoff’s deprecation commands depend on MSG being set in the same shell, so running them independently can remove deprecation notices instead of applying them.

1 open issue
What changed in this PR

Adds a manual npm deprecation step to the v1 release procedure, addressing #2954 so newly published v1 versions receive the existing deprecation notice.

Changes:

  • Documents exact-version deprecation for all four packages, with maintainer-run commands and two-factor authentication guidance.
  • Adds warnings about version ranges and empty messages, plus verification of v1 notices and unaffected v2 releases.
  • Adds deprecation to the release issue checklist and renumbers the advisory release-notes step.
File Description
.claude/​skills/​release/​SKILL.md Extends the v1 release procedure with manual deprecation and verification instructions.

Review effort: Balanced

Comment thread .claude/skills/release/SKILL.md Resolved
A shell variable is empty in a fresh ! invocation, which would lift
the notice instead of applying it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the release-skill documentation update.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@cliffhall

Copy link
Copy Markdown
Member Author

Copilot review loop closed — exit: clean round (round 2, no inline comments, no suppressed findings).

  • Round 1: 1 finding — handoff commands depended on MSG being set in the same shell, so a fresh ! invocation would pass an empty message and lift deprecation. Fixed: the message is now inlined in each of the four commands.
  • Round 2: clean.

@cliffhall
cliffhall merged commit e023e3e into v2/main Nov 12, 2026
12 checks passed
@cliffhall
cliffhall deleted the v2/docs/2954-release-v1-deprecate-step branch November 12, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Issues and PRs for v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release skill: add a final v1 step that walks the maintainer through npm deprecate

2 participants