fix: fallback copy for Servers File and Server Entry buttons#1128
Open
MumuTW wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: fallback copy for Servers File and Server Entry buttons#1128MumuTW wants to merge 2 commits intomodelcontextprotocol:mainfrom
MumuTW wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigator.clipboard.writeTextwhen available and fall back todocument.execCommand("copy")Why
In non-secure or restricted contexts,
navigator.clipboard.writeTextcan fail (for exampleNotAllowedError). This caused copy actions to show an error instead of copying. The fallback restores copy behavior for those contexts.Testing
cd client && npm test -- --runTestsByPath src/components/__tests__/Sidebar.test.tsxCloses #913