fix: prevent dual Content-Type header in OAuth token requests#1122
Open
peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: prevent dual Content-Type header in OAuth token requests#1122peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…ect connections The custom fetch wrappers for direct SSE and Streamable HTTP transports were overwriting or conflicting with headers set by the SDK's OAuth token requests. This caused authorization servers (e.g. Keycloak) to reject token exchanges with "Failed to parse media type application/json, application/x-www-form-urlencoded". Move default accept/content-type headers out of the fetch wrapper and into requestInit.headers with lowercase keys, and simplify the custom fetch to a pass-through. The SDK's createFetchWithInit merges defaults with per-request headers (per-request wins), so OAuth token requests now correctly use application/x-www-form-urlencoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed to parse media type application/json, application/x-www-form-urlencodedwhen using direct SSE or Streamable HTTP transports.Content-Type: application/jsonandAccept: application/json, text/event-streamheaders. When the SDK's OAuth layer issued token requests withContent-Type: application/x-www-form-urlencoded, the headers were merged, producing a malformed dual Content-Type value.requestInit.headerswith lowercase keys. Simplify the custom fetch to a pass-through. The SDK'screateFetchWithInitmerges defaults with per-request headers (per-request wins), so OAuth token requests now correctly useapplication/x-www-form-urlencoded.Test plan
npm run build-clientpassescd client && npm run lintpasses